Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBNTR-224] Letting user reset row expansion in Advanced Table #3269

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Mar 21, 2024

What does this PR do?
Update the Advanced Table kit's expansion logic so that it does not override the KPIs page when we reset/remove row expansions.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@carloslimasd carloslimasd added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) alpha labels Mar 21, 2024
@carloslimasd carloslimasd self-assigned this Mar 21, 2024
@carloslimasd carloslimasd requested review from a team as code owners March 21, 2024 21:09
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.21.0.pre.alpha.PBNTR224letuserresetrowexpansion2441

Your Alpha for NPM is 13.21.0-alpha.PBNTR224letuserresetrowexpansion2441

Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.21.0.pre.alpha.PBNTR224letuserresetrowexpansion2466

Your Alpha for NPM is 13.21.0-alpha.PBNTR224letuserresetrowexpansion2466

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-224-let-user-reset-row-expansion

@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Code Approved Approved by a Playbook Admin labels Mar 28, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Mar 29, 2024
Merged via the queue into master with commit a3d12d0 Mar 29, 2024
6 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-224-let-user-reset-row-expansion branch March 29, 2024 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants