Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBNTR-243] Global Positioning Props to Allow Inset Value #3289

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Mar 26, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Adds the option to pass in an inset to the global positioning prop to provide for edge cases like the Avatar kit

Screenshots: Screenshots to visualize your addition/change

Screenshot 2024-03-27 at 8 12 19 AM

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Mar 26, 2024
@nidaqg nidaqg self-assigned this Mar 26, 2024
@nidaqg nidaqg marked this pull request as ready for review March 27, 2024 12:42
@nidaqg nidaqg requested review from a team as code owners March 27, 2024 12:42
@nidaqg nidaqg added the alpha label Mar 27, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.21.0.pre.alpha.PBNTR243globalpositioningpropinset2504

Your Alpha for NPM is 13.21.0-alpha.PBNTR243globalpositioningpropinset2504

@nidaqg nidaqg requested a review from jasperfurniss March 27, 2024 14:29
@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Code Approved Approved by a Playbook Admin labels Mar 27, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Mar 29, 2024
Merged via the queue into master with commit df3012e Mar 29, 2024
6 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-243-global-positioning-prop-inset branch March 29, 2024 15:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants