Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBNTR-242] Hotfix: Remove advanced_table_example_mock_data.rb #3318

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

thestephenmarshall
Copy link
Contributor

@thestephenmarshall thestephenmarshall commented Apr 1, 2024

What does this PR do? A clear and concise description with your runway ticket url.

advanced_table_example_mock_data.rb is causing the site to crash repeatedly. The file isn't being used and is not a module, so Zeitwerk fails to autoload it.

Screenshot 2024-04-01 at 11 50 21 AM

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@thestephenmarshall thestephenmarshall requested review from a team as code owners April 1, 2024 15:50
@thestephenmarshall thestephenmarshall self-assigned this Apr 1, 2024
@thestephenmarshall thestephenmarshall added milano 20 MAX - Deploy this PR to a review environment via Milano bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Apr 1, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Apr 1, 2024
Merged via the queue into master with commit 70e8063 Apr 1, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-242-hotfix branch April 1, 2024 16:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants