Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-1284] Investigation: Test Typeahead with Consideration for New Prop for MenuList #3324

Merged
merged 3 commits into from
Apr 5, 2024
Merged

[PLAY-1284] Investigation: Test Typeahead with Consideration for New Prop for MenuList #3324

merged 3 commits into from
Apr 5, 2024

Conversation

thestephenmarshall
Copy link
Contributor

@thestephenmarshall thestephenmarshall commented Apr 2, 2024 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.

  • Investigate the limitations of the typeahead functionality, referencing PBHUB-60, and explore potential solutions.
  • Determine whether the desired enhancements can be achieved without introducing a new prop.
  • Evaluate whether introducing a new prop is the appropriate approach to address the identified limitations.

Screenshots: Screenshots to visualize your addition/change

Screenshot 2024-04-02 at 3 24 46 PM

How to test? Steps to confirm the desired behavior:

  1. Go to kits/typeahead/react#custom-menulist
  2. Click on typeahead
  3. Click "Load More" to expand the list
  • "Load More" <Button/> is a footer prop passed to our imported <MenuList/> component

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@thestephenmarshall thestephenmarshall requested review from a team as code owners April 2, 2024 19:26
@thestephenmarshall thestephenmarshall self-assigned this Apr 2, 2024
@thestephenmarshall thestephenmarshall added milano 20 MAX - Deploy this PR to a review environment via Milano enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Apr 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.23.0.pre.alpha.PLAY1284investigation2657

Your Alpha for NPM is 13.23.0-alpha.PLAY1284investigation2657

@jasperfurniss jasperfurniss added this pull request to the merge queue Apr 5, 2024
Merged via the queue into master with commit dfd4b7b Apr 5, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1284-investigation branch April 5, 2024 20:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@thestephenmarshall thestephenmarshall

Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thestephenmarshall @jasperfurniss