Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1282] Update badge color for readability #3327

Closed

Conversation

ElisaShapiro
Copy link
Contributor

@ElisaShapiro ElisaShapiro commented Apr 3, 2024

What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1282 updates the neutral font color for the default variant of the badge kit from the standard slate to a more legible Light font ($text_lt_light).

Screenshots: A side by side of current (left) and new (right) default variation of badge color
badge side by side

How to test? Steps to confirm the desired behavior:

  1. Go to https://playbook.powerapp.cloud/kits/badge/rails
  2. Scroll down to colors example
  3. See change to default variation font color

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
    - [ ] TESTS I have added test coverage to my code.

@ElisaShapiro ElisaShapiro added the enhancement New Features, Props, & Variants (USED IN CHANGELOG) label Apr 3, 2024
@ElisaShapiro ElisaShapiro self-assigned this Apr 3, 2024
@ElisaShapiro ElisaShapiro added the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 3, 2024
@ElisaShapiro ElisaShapiro marked this pull request as ready for review April 3, 2024 14:27
@ElisaShapiro ElisaShapiro requested review from a team as code owners April 3, 2024 14:27
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Apr 5, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Apr 5, 2024
@jasperfurniss
Copy link
Contributor

Closing in favor of #3347 (verified commits)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants