Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1297] Update text styles to prevent inconsistent Tiptap output #3340

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

ElisaShapiro
Copy link
Contributor

@ElisaShapiro ElisaShapiro commented Apr 4, 2024

What does this PR do?
PLAY-1297 adjusts the italic and bold text style in the body kit so they exhibit predictable behavior when used in text editors. See technical details of runway ticket for explicit changes made as interim step before a more comprehensive PBHUB ticket improves upon this (runway ticket also links to the prior investigations that prompted this change).

Screenshots: Screenshots from code sandboxes (left = previous version; right = new alpha)
before code sandboxafter code sandbox

How to test? Steps to confirm the desired behavior:

  1. Review code sandbox with new alpha provided in runway ticket.
  2. Test italicization: italicized/emphasized text should become italicized (but not bold).
  3. Test bold links: a link that is then made bold should show a bold, blue hyperlink; bold text that is turned into a link should show a bold, blue hyperlink as well.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
    - [ ] TESTS I have added test coverage to my code.

@ElisaShapiro ElisaShapiro added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Apr 4, 2024
@ElisaShapiro ElisaShapiro self-assigned this Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.22.0.pre.alpha.PLAY1297updatetextstyles2636

Your Alpha for NPM is 13.22.0-alpha.PLAY1297updatetextstyles2636

@ElisaShapiro ElisaShapiro added the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 4, 2024
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Apr 5, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Apr 5, 2024
@ElisaShapiro ElisaShapiro marked this pull request as ready for review April 5, 2024 14:45
@ElisaShapiro ElisaShapiro requested review from a team as code owners April 5, 2024 14:45
@jasperfurniss jasperfurniss added this pull request to the merge queue Apr 5, 2024
Merged via the queue into master with commit 29bbfdf Apr 5, 2024
9 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1297-update-text-styles branch April 5, 2024 19:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants