Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBNTR-268] Dropdown Kit v2 #3355

Merged
merged 34 commits into from
Apr 12, 2024
Merged

[PBNTR-268] Dropdown Kit v2 #3355

merged 34 commits into from
Apr 12, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Apr 11, 2024

What does this PR do? A clear and concise description with your runway ticket url.
Runway Story

  • ✅ Put the autocomplete functionality behind a prop with default to ‘false’
  • ✅ styling for input is now more like the select and no typing involved
  • ✅ Made it so if dev wants the default input, they do not have to pass in Dropdown.Trigger, it renders by default.
  • ✅ Made it so if dev does not want any props, etc for Dropdown.Container, they do not have to pass in that subkit. if not passed in, it renders by default.
  • ✅ Height of input field
  • ✅ Better Typescript typing (no ‘any’ types')

Screenshots: Screenshots to visualize your addition/change

Screenshot 2024-04-12 at 10 20 44 AM

Screenshot 2024-04-12 at 10 21 05 AM

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Apr 11, 2024
@nidaqg nidaqg self-assigned this Apr 11, 2024
@nidaqg nidaqg marked this pull request as ready for review April 12, 2024 14:14
@nidaqg nidaqg requested review from a team as code owners April 12, 2024 14:14
@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Code Approved Approved by a Playbook Admin labels Apr 12, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Apr 12, 2024
Merged via the queue into master with commit 2c95d41 Apr 12, 2024
6 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-268-Dropdown-kit-v2 branch April 12, 2024 16:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants