[PLAY-1126] add px to Max Width global prop values left aligned #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElisaShapiro
added
milano
thestephenmarshall
previously approved these changes
Apr 11, 2024
jasperfurniss
previously approved these changes
Apr 12, 2024
ElisaShapiro
dismissed stale reviews from jasperfurniss and thestephenmarshall
via
101954a
nidaqg
approved these changes
Apr 12, 2024
nidaqg
added
Product Approved
jasperfurniss
deleted the
PLAY-1126-add-px-to-Max-Width-global-prop-values
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1126 adds the pixel values for each MaxWidth prop value to the visual guide on the guideline page (see runway ticket for specific designer feedback and context). Pixel values sourced from here.
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.