Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1304] fix Kit Collection page when Pagination is present #3369

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

ElisaShapiro
Copy link
Contributor

@ElisaShapiro ElisaShapiro commented Apr 24, 2024

What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1304 allows for pagination to appear in a kit_collection. This ticket is similar to one noticed on the Navigation kit_show page due to Pagination which was fixed in PLAY-1266.

I have also removed the kit_collection_show method from the pages controller as it has been made redundant by kit_collection_show_rails and kit_collection_show_react (side note: doesn't look like there is the ability to see a swift kit_collection yet on live per my testing example here). The routes and kit_collection view must remain unchanged or there is funky behavior with the URL/query parameters and too much defaulting to rails.

Screenshots:
Screenshots below show Pagination appearing in kit collection when 1st or subsequent item in the kit collection
pagination appears in kit collection
pagination appears in kit collection when first item

How to test? Steps to confirm the desired behavior:

  1. Go to a kit collection with pagination included (Table and Pagination, Pagination and Table, Table and Pagination with /rails in URL)
  2. If not already on Pagination in Nav, click on Pagination Nav tab
  3. Pagination kit example should appear in kit_collection view without error

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
    - [ ] TESTS I have added test coverage to my code.

@ElisaShapiro ElisaShapiro added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Apr 24, 2024
@ElisaShapiro ElisaShapiro self-assigned this Apr 24, 2024
@ElisaShapiro ElisaShapiro requested review from a team as code owners April 24, 2024 16:53
@ElisaShapiro ElisaShapiro added the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 24, 2024
@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Apr 26, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Apr 26, 2024
@co1in-1ewis co1in-1ewis removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 26, 2024
@nidaqg nidaqg added this pull request to the merge queue Apr 26, 2024
Merged via the queue into master with commit ed6b461 Apr 26, 2024
8 checks passed
@nidaqg nidaqg deleted the PLAY-1304-fix-kit-collection-pagination branch April 26, 2024 14:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) Code Approved Approved by a Playbook Admin Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants