[PLAY-1304] fix Kit Collection page when Pagination is present #3369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1304 allows for pagination to appear in a kit_collection. This ticket is similar to one noticed on the Navigation kit_show page due to Pagination which was fixed in PLAY-1266.
I have also removed the
kit_collection_show
method from the pages controller as it has been made redundant bykit_collection_show_rails
andkit_collection_show_react
(side note: doesn't look like there is the ability to see a swift kit_collection yet on live per my testing example here). The routes and kit_collection view must remain unchanged or there is funky behavior with the URL/query parameters and too much defaulting to rails.Screenshots:


Screenshots below show Pagination appearing in kit collection when 1st or subsequent item in the kit collection
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.