Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PBNTR-277] fix Bar Graph axisTitle requirement #3372

Merged
merged 2 commits into from
May 1, 2024
Merged

[PBNTR-277] fix Bar Graph axisTitle requirement #3372

merged 2 commits into from
May 1, 2024

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Apr 26, 2024 •
edited
Loading

PBNTR-277

This PR allows devs to not have to pass in the axisTitle prop.

How to test? Steps to confirm the desired behavior:
Pull to your local and removed a axisTitle prop and see if the graph still loads

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 26, 2024
@nickamantia nickamantia removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 29, 2024
@nickamantia nickamantia changed the title bar-chart-axis-title [PBNTR-277] fix Bar Graph axisTitle requirement Apr 29, 2024
@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 29, 2024
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.25.0.pre.alpha.barchartfix2766

Your Alpha for NPM is 13.25.0-alpha.barchartfix2766

@nickamantia nickamantia marked this pull request as ready for review April 29, 2024 20:13
@nickamantia nickamantia requested review from a team as code owners April 29, 2024 20:13
@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) Code Approved Approved by a Playbook Admin labels Apr 29, 2024
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Apr 30, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue May 1, 2024
Merged via the queue into master with commit 6f601d3 May 1, 2024
9 checks passed
@jasperfurniss jasperfurniss deleted the bar-chart-fix branch May 1, 2024 14:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@nidaqg nidaqg nidaqg approved these changes

Assignees

@nickamantia nickamantia

Labels
alpha bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickamantia @jasperfurniss @nidaqg @GordonHodanich @co1in-1ewis