-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[PBNTR-260] Avatar componentOverlay variant [corner positions] #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncypret
reviewed
May 1, 2024
playbook/app/pb_kits/playbook/pb_avatar/docs/_avatar_component_overlay.html.erb
Outdated
Show resolved
Hide resolved
playbook/app/pb_kits/playbook/pb_avatar/docs/_avatar_component_overlay.jsx
Outdated
Show resolved
Hide resolved
nidaqg
approved these changes
May 2, 2024
jasperfurniss
approved these changes
May 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Code Approved
Approved by a Playbook Admin
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
Product Approved
pending technical review, OK to merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBNTR-260
This PR adds the new
componentOverlay
prop to the avatar kit.This prop creates a
iconCircle
orbadge
variants to the avatar kit.<Avatar componentOverlay={{ component: "iconCircle", icon: "plus", placement: "bottom-right" }} imageUrl="https://randomuser.me/api/portraits/men/44.jpg" size="xxs" />
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.