Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBNTR-260] Avatar componentOverlay variant [corner positions] #3382

Merged
merged 12 commits into from
May 3, 2024

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Apr 30, 2024

PBNTR-260

This PR adds the new componentOverlay prop to the avatar kit.
This prop creates a iconCircle or badge variants to the avatar kit.

<Avatar componentOverlay={{ component: "iconCircle", icon: "plus", placement: "bottom-right" }} imageUrl="https://randomuser.me/api/portraits/men/44.jpg" size="xxs" />

Screenshot 2024-04-30 at 2 25 46 PM

How to test? Steps to confirm the desired behavior:

  1. Go to the avatar kit and see if styles are correct.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 30, 2024
@nickamantia nickamantia self-assigned this Apr 30, 2024
@nickamantia nickamantia marked this pull request as ready for review April 30, 2024 18:45
@nickamantia nickamantia requested review from a team as code owners April 30, 2024 18:45
@nidaqg nidaqg added the enhancement New Features, Props, & Variants (USED IN CHANGELOG) label May 2, 2024
@nidaqg nidaqg changed the title [PBNTR-260] Avatar status variant [corner positions] [PBNTR-260] Avatar componentOverlay variant [corner positions] May 2, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label May 2, 2024
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label May 2, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue May 3, 2024
Merged via the queue into master with commit e85aef0 May 3, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the pbntr-260-avatar-status-variant-global branch May 3, 2024 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants