Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update milano links #3386

Merged
merged 1 commit into from
May 2, 2024
Merged

Update milano links #3386

merged 1 commit into from
May 2, 2024

Conversation

thestephenmarshall
Copy link
Contributor

@thestephenmarshall thestephenmarshall commented May 2, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Updates Milano log links in all envs

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to this deployment
  2. Click on the logs link and metrics link
  3. Verify both are using the correct env

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@thestephenmarshall thestephenmarshall requested review from a team as code owners May 2, 2024 17:02
@thestephenmarshall thestephenmarshall self-assigned this May 2, 2024
@thestephenmarshall thestephenmarshall added the milano 20 MAX - Deploy this PR to a review environment via Milano label May 2, 2024
@thestephenmarshall
Copy link
Contributor Author

Screenshot 2024-05-02 at 3 50 56 PM

Verified to be working for review envs.

@jasperfurniss
Copy link
Contributor

I had to do some digging in nitro because i didn't realize we were dropping kibana for splunk. https://github.com/powerhome/nitro-web/pull/39132/files

Okey dokey. Thanks @thestephenmarshall 🚢 🚢

@thestephenmarshall thestephenmarshall added this pull request to the merge queue May 2, 2024
Merged via the queue into master with commit 3393d7a May 2, 2024
5 checks passed
@thestephenmarshall thestephenmarshall deleted the update-metric-logs-links branch May 2, 2024 20:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants