Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1307] add Loading Inline custom text option #3387

Merged

Conversation

ElisaShapiro
Copy link
Contributor

@ElisaShapiro ElisaShapiro commented May 2, 2024

What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1307 adds a text prop with a default value of 'Loading' to the Loading Inline kit, and adds a Custom Text kit example showing developers how to customize their Loading Inline components with the new prop. Both the Rails and React versions of the kit have been updated, as have their tests.

In the course of this ticket I also standardized the primary Loading Inline example's name as "default" instead of "light" which was set ~5 years ago - the name is now "default" consistently across Rails and React files and kit example pages.

Screenshots: Screenshots of Custom Text kit example on Rails and React kit pages
Rails custom text example
React custom text example

How to test? Steps to confirm the desired behavior:

  1. Go to Loading Inline kit page (rails and react).
  2. Scroll down to 'Custom Text' kit example.
  3. See added kit example and select '</> Show Code' to see how custom text values are set.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

…text kit examples, update tests in rails and react
@ElisaShapiro ElisaShapiro added the enhancement New Features, Props, & Variants (USED IN CHANGELOG) label May 2, 2024
@ElisaShapiro ElisaShapiro self-assigned this May 2, 2024
@ElisaShapiro ElisaShapiro added the milano 20 MAX - Deploy this PR to a review environment via Milano label May 2, 2024
@ElisaShapiro ElisaShapiro marked this pull request as ready for review May 2, 2024 20:47
@ElisaShapiro ElisaShapiro requested review from a team as code owners May 2, 2024 20:47
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label May 3, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue May 3, 2024
Merged via the queue into master with commit 5fa513a May 3, 2024
6 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1307-add-Loading-Inline-custom-text-option branch May 3, 2024 15:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants