Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBNTR-294] Fix for Nitro Style bleed with Pagination kit #3408

Merged
merged 1 commit into from
May 20, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented May 14, 2024

What does this PR do? A clear and concise description with your runway ticket url.

RUNWAY STORY

  • old-styles SCSS in Nitro was overriding the padding within pagination kit.
  • adding this important tag should fix the issue

Screenshots: Screenshots to visualize your addition/change

Screenshot 2024-05-14 at 9 21 01 AM

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels May 14, 2024
@nidaqg nidaqg self-assigned this May 14, 2024
@nidaqg nidaqg requested review from a team as code owners May 14, 2024 13:21
@nidaqg nidaqg added the alpha label May 14, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.27.0.pre.alpha.PBNTR294paginationstylingfix2899

Your Alpha for NPM is 13.27.0-alpha.PBNTR294paginationstylingfix2899

@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label May 15, 2024
Copy link
Contributor

@nickamantia nickamantia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasperfurniss jasperfurniss added this pull request to the merge queue May 20, 2024
Merged via the queue into master with commit 0dbb562 May 20, 2024
8 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-294-pagination-styling-fix branch May 20, 2024 13:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants