[PBNTR-308] Dropdown Custom Option Padding #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
the
milano
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=dropdown-custom-option-fix |
nidaqg
added
enhancement
nidaqg
changed the title
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.27.0.pre.alpha.dropdowncustomoptionfix2924 Your Alpha for NPM is 13.27.0-alpha.dropdowncustomoptionfix2924 |
carloslimasd
approved these changes
May 20, 2024
thestephenmarshall
approved these changes
May 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Runway Story
The Dropdown Option had an additional Flex which was adding padding in addition to the overall padding. This additional padding could not be overridden using global props so devs could not really achieve padding="none" if they needed to.
This PR removes that additional Flex and moves other pieces around to maintain the default UI but allow devs to remove all padding if needed.
csb with alpha with no padding
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.