Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1755] Update pb_content_tag #4324

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yuriyivanenko
Copy link
Contributor

@yuriyivanenko yuriyivanenko commented Feb 25, 2025

What does this PR do? A clear and concise description with your runway ticket url.

This PR updates the Select, Selectable Card, Selectable Card Icon and Selectable Icon to use the new pb_content_tag.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@yuriyivanenko yuriyivanenko added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Feb 25, 2025
@yuriyivanenko yuriyivanenko self-assigned this Feb 25, 2025
@yuriyivanenko yuriyivanenko marked this pull request as ready for review February 25, 2025 20:56
@yuriyivanenko yuriyivanenko requested a review from a team as a code owner February 25, 2025 20:56
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.14.0.pre.alpha.play1755pbcontenttag6327

Your Alpha for NPM is 14.14.0-alpha.play1755pbcontenttag6327

Copy link
Contributor

@markdoeswork markdoeswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@nidaqg nidaqg added Code Approved Approved by a Playbook Admin and removed Needs Review labels Feb 26, 2025
@yuriyivanenko yuriyivanenko removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 26, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants