Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Module Replication: MongoDB & MySQL support #133

Merged
merged 366 commits into from
Nov 27, 2024

Conversation

rkistner
Copy link
Contributor

This is a major refactor to support modular replication, and adds initial support for MongoDB and MySQL source databases.

Opening the PR to start the process of getting this into the stable builds.

stevensJourney and others added 30 commits August 14, 2024 14:12
Simplified configuration of Replication module
…onfig. Added DatabaseSchemaV2 type to remove Postgres fields.
Moved Replication Module definition to the replication packaged
Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: cd698ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@powersync/service-module-mongodb Minor
@powersync/service-module-mysql Minor
@powersync/service-image Major
@powersync/service-core Minor
@powersync/lib-services-framework Minor
@powersync/service-sync-rules Minor
@powersync/service-module-postgres Patch
@powersync/service-rsocket-router Patch
@powersync/service-types Minor
@powersync/service-jpgwire Minor
test-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

rkistner and others added 3 commits November 14, 2024 16:28
* Proof-of-concept: json_each support in parameter queries.

* Extract out json_each.

* Fixes.

* Tweak usesDangerousRequestParameters check.

* Fix handling of nested json.

* Fix tableName regression.

* Add changeset.

---------

Co-authored-by: stevensJourney <51082125+stevensJourney@users.noreply.github.com>
stevensJourney
stevensJourney previously approved these changes Nov 25, 2024
Rentacookie
Rentacookie previously approved these changes Nov 25, 2024
Copy link
Contributor

@Rentacookie Rentacookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Made a few comments - mostly related to some version discrepancies with some dependencies used in the modules and service and some mentions of Postgres in the MySQL and Mongo modules.
No blockers that I could see though.

* remove postgres errors from mysql+mongodb rate limiters

* use common typescript version

* update changeset

* update zongji package
@stevensJourney stevensJourney dismissed stale reviews from Rentacookie and themself via cd698ac November 26, 2024 14:50
@stevensJourney stevensJourney marked this pull request as ready for review November 27, 2024 07:20
@stevensJourney stevensJourney merged commit 57bd18b into main Nov 27, 2024
15 checks passed
@rkistner rkistner deleted the feat/modular-replication-architecture branch December 9, 2024 07:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants