-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Module Replication: MongoDB & MySQL support #133
Conversation
Simplified configuration of Replication module
…onfig. Added DatabaseSchemaV2 type to remove Postgres fields.
…ive to the ReplicationAdapter
Fixed test imports
Moved Replication Module definition to the replication packaged
…cture' into mongodb-skip-currentdata
[MongoDB] Fix initial snapshot / Better error recovery
…cture' into mongodb-skip-currentdata
[MongoDB] Skip current_data storage
…cture' into update-beta
🦋 Changeset detectedLatest commit: cd698ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Update beta branch
* Proof-of-concept: json_each support in parameter queries. * Extract out json_each. * Fixes. * Tweak usesDangerousRequestParameters check. * Fix handling of nested json. * Fix tableName regression. * Add changeset. --------- Co-authored-by: stevensJourney <51082125+stevensJourney@users.noreply.github.com>
modules/module-mongodb/src/replication/MongoErrorRateLimiter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Made a few comments - mostly related to some version discrepancies with some dependencies used in the modules and service and some mentions of Postgres in the MySQL and Mongo modules.
No blockers that I could see though.
* remove postgres errors from mysql+mongodb rate limiters * use common typescript version * update changeset * update zongji package
cd698ac
This is a major refactor to support modular replication, and adds initial support for MongoDB and MySQL source databases.
Opening the PR to start the process of getting this into the stable builds.