-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test case for filtering null and not null on relation #539
base: master
Are you sure you want to change the base?
test case for filtering null and not null on relation #539
Conversation
Oh I see. I think the issue is simply that we always I am currently only working on a sequelize project. Sequelize has the |
58ee944
to
be99407
Compare
@ppetzold I fixed the null queries on relationships by storing that when we use a relationship in a filter that it should be inner joined. On top of that I allow the user to configure the default join method, and the join method per column, since this all converged on the same approach I needed to extend for building the relationships either way. Oh and and !!! IMPORTANT ! Important It also fixes an error in the following scenario:
Using that filter without including the
That's fixed now! Whenever you use a relationship in filter it is automatically inner joined :) This PR is ready for review :) |
@ppetzold can you take a look here? |
@ppetzold ping |
…se-null-on-relations
As discussed, I've written a new test case for checking $null on relations, and changed the existing test case for checking properly on $not:$null on relations. The first test case is failing as expected/described within the issue. Since this is my first time working on this repo (and submitting a PR to an open source project in general), let me know if this is fine.
Issue #538