Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Holding keys to change volume only changes it once, and cannot scroll to change volume in some screens #31267

Closed
Lemmmy opened this issue Dec 25, 2024 · 9 comments
Assignees

Comments

@Lemmmy
Copy link

Lemmmy commented Dec 25, 2024

Type

Game behaviour

Bug description

As of the latest lazer update, there's a few very noticable changes to volume control behaviour. I'm not sure if any of these are intentional, or a regression caused by #31146 or #31147?

  • In the main menu and gameplay, holding down the keys I have bound for volume either don't change the volume at all, or change it by only one increment if the volume controls are already visible. Alt+scroll still works as expected here (and in song select, too). Holding down a key worked in previous versions. Fixed by Fix volume adjust key repeat not working as expected #31282.
  • In several screens, alt+scroll to change the volume no longer works at all. This worked in the previous version. As far as I can tell, there's no way to change the volume in these screens anymore? Screens not working:
    • Daily challenge (this is the only one I'm certain worked before)
    • Song results
    • Multi list
    • Multi room
    • Playlist list
    • Playlist room
    • Beatmap editor (keybinds do work here)
    • Skin editor (keybinds do work here)

Screenshots or videos

Img.6897.mp4

Apologies for crude video, didn't have any kind of input overlays on hand

My keybindings:

osu!_77ocNY7vXB

Version

2024.1224.1-lazer

Logs

compressed-logs.zip

@peppy
Copy link
Member

peppy commented Dec 26, 2024

To fix alt-scroll, I believe we should add a second global binding for this (and not do explicit implementation again as it was before).

For the other cases it sounds like a presence issue.

In several screens, alt+scroll to change the volume no longer works at all. This worked in the previous version. As far as I can tell, there's no way to change the volume in these screens anymore?

You can still use global bindings to adjust volume. You can also use the toolbar.

peppy added a commit to peppy/osu that referenced this issue Dec 26, 2024
This offers the defaults users have come to expect while also allowing
rebinding (if they don't want it) and better compatibility with other
global actions (since this is no longer implemented using `OnScroll`
event flow).

Addresses part of ppy#31267.
@peppy peppy self-assigned this Dec 26, 2024
peppy added a commit to peppy/osu that referenced this issue Dec 26, 2024
@Lemmmy
Copy link
Author

Lemmmy commented Dec 26, 2024

Thanks for fixing both issues!

You can still use global bindings to adjust volume. You can also use the toolbar.

It probably doesn't help that my global bindings are just letter keys, so they don't seem to work in any screen with a textbox (unless there's a way to unfocus the textbox I'm probably missing?). But I'm happy to accept this as a "user error, stupid bindings" knowing that the Alt issue is just a regression.

Scrolling on now playing on the toolbar is great to know though—thanks for that.

@TheEZIC
Copy link

TheEZIC commented Dec 31, 2024

The same issues applies to score result screen

@GGchung69
Copy link

got a new update but scroll is still broken

@peppy
Copy link
Member

peppy commented Jan 1, 2025

got a new update but scroll is still broken

what issue are you seeing?

@GGchung69
Copy link

same as the author

@Lemmmy
Copy link
Author

Lemmmy commented Jan 1, 2025

same as the author

The fix hasn't been merged (so isn't in the game) yet: #31281

@GGchung69
Copy link

oh

@peppy
Copy link
Member

peppy commented Jan 21, 2025

I don't believe fixing the remaining portion of this issue is in our best interest.

For users which are not happy with this, here's some alternatives:

  • You can bind alt-scroll in settings to your volume adjust – it will work everywhere again (but it will override some things like editor distance adjust).
  • You can scroll over the volume icon on the toolbar to adjust volume even without holding alt:

Image

Going to close this one out for now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants