Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for "freestyle" in multiplayer #31260

Merged
merged 42 commits into from
Feb 4, 2025

Merge branch 'master' into multiplayer-free-style

a93dabd
Select commit
Loading
Failed to load commit list.
# for the full log view
Merged

Add support for "freestyle" in multiplayer #31260

Merge branch 'master' into multiplayer-free-style
a93dabd
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Feb 4, 2025 in 0s

43635 passed, 1 failed and 320 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 10908✅ 1❌ 80⚪ 2450s
TestResults-Linux-SingleThread.trx 10909✅ 80⚪ 2021s
TestResults-Windows-MultiThreaded.trx 10909✅ 80⚪ 3205s
TestResults-Windows-SingleThread.trx 10909✅ 80⚪ 2516s

❌ TestResults-Linux-MultiThreaded.trx

10989 tests were completed in 2450s with 10908 passed, 1 failed and 80 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Navigation.TestSceneSkinEditorNavigation 41✅ 1❌ 35s

❌ osu.Game.Tests.Visual.Navigation.TestSceneSkinEditorNavigation

✅ TestAutoplayCompatibleModsRetainedOnEnteringGameplay
✅ TestAutoplayCompatibleModsRetainedOnEnteringGameplay
✅ TestAutoplayIncompatibleModsRemovedOnEnteringGameplay
✅ TestAutoplayIncompatibleModsRemovedOnEnteringGameplay
✅ TestChangeToNonSkinnableScreen
✅ TestChangeToNonSkinnableScreen
✅ TestCinemaModRemovedOnEnteringGameplay
✅ TestCinemaModRemovedOnEnteringGameplay
✅ TestComponentsDeselectedOnSkinEditorHide
✅ TestComponentsDeselectedOnSkinEditorHide
✅ TestConstructor
✅ TestConstructor
✅ TestDuplicateAutoplayModRemovedOnEnteringGameplay
✅ TestDuplicateAutoplayModRemovedOnEnteringGameplay
✅ TestEditComponentFromGameplayScene
✅ TestEditComponentFromGameplayScene
✅ TestGameplaySettingsDoesNotExpandWhenSkinOverlayPresent
✅ TestGameplaySettingsDoesNotExpandWhenSkinOverlayPresent
✅ TestModOverlayClosesOnOpeningSkinEditor
✅ TestModOverlayClosesOnOpeningSkinEditor
✅ TestMutateProtectedSkinDuringGameplay
✅ TestMutateProtectedSkinDuringGameplay
✅ TestMutateProtectedSkinFromMainMenu_UndoToInitialStateIsCorrect
✅ TestMutateProtectedSkinFromMainMenu_UndoToInitialStateIsCorrect
❌ TestMutateProtectedSkinFromPlayer_UndoToInitialStateIsCorrect
	accuracy meter state unchanged: Expected string length 361 but was 356. Strings differ at index 138.
	  Expected: "...eyToken=null","Position":{"x":-20.0,"y":20.0},"Rotation":0..."
	  But was:  "...eyToken=null","Position":{"x":0.0,"y":0.0},"Rotation":0.0,..."
	  --------------------------------------------^
	
✅ TestMutateProtectedSkinFromPlayer_UndoToInitialStateIsCorrect
✅ TestOpenSkinEditorGameplaySceneOnBeatmapWithNoObjects
✅ TestOpenSkinEditorGameplaySceneOnBeatmapWithNoObjects
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(1)
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(1)
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(2)
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(2)
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(3)
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(3)
✅ TestOpenSkinEditorGameplaySceneWhenDummyBeatmapActive
✅ TestOpenSkinEditorGameplaySceneWhenDummyBeatmapActive
✅ TestRulesetInputDisabledWhenSkinEditorOpen
✅ TestRulesetInputDisabledWhenSkinEditorOpen
✅ TestSkinSavesOnChange
✅ TestSkinSavesOnChange
✅ TestSwitchScreenWhileDraggingComponent
✅ TestSwitchScreenWhileDraggingComponent

✅ TestResults-Linux-SingleThread.trx

10989 tests were completed in 2021s with 10909 passed, 0 failed and 80 skipped.

✅ TestResults-Windows-MultiThreaded.trx

10989 tests were completed in 3205s with 10909 passed, 0 failed and 80 skipped.

✅ TestResults-Windows-SingleThread.trx

10989 tests were completed in 2516s with 10909 passed, 0 failed and 80 skipped.

Annotations

Check failure on line 172 in osu.Game.Tests/Visual/Navigation/TestSceneSkinEditorNavigation.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Navigation.TestSceneSkinEditorNavigation ► TestMutateProtectedSkinFromPlayer_UndoToInitialStateIsCorrect

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
Error:
  accuracy meter state unchanged: Expected string length 361 but was 356. Strings differ at index 138.
    Expected: "...eyToken=null","Position":{"x":-20.0,"y":20.0},"Rotation":0..."
    But was:  "...eyToken=null","Position":{"x":0.0,"y":0.0},"Rotation":0.0,..."
    --------------------------------------------^
  
Raw output
accuracy meter state unchanged: Expected string length 361 but was 356. Strings differ at index 138.
  Expected: "...eyToken=null","Position":{"x":-20.0,"y":20.0},"Rotation":0..."
  But was:  "...eyToken=null","Position":{"x":0.0,"y":0.0},"Rotation":0.0,..."
  --------------------------------------------^

   at osu.Game.Tests.Visual.Navigation.TestSceneSkinEditorNavigation.TestMutateProtectedSkinFromPlayer_UndoToInitialStateIsCorrect() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/Navigation/TestSceneSkinEditorNavigation.cs:line 172