-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
All circles mod (converts sliders into circles) #31719
base: master
Are you sure you want to change the base?
Conversation
Wow, this is actually so cool. Definitely would be fun to have in lazer! |
As for the description, I thought of: " |
Staccato's definitely a fun one, but yeah I think recognizability and the most straightforward acronym being unavailable is an issue. "Circles Only" is definitely a contender
Love it. |
We already have "AC" (Accuracy Challenge) so "CO" is probably better (overlaps with mania COver mod, but probably fine). |
I've updated the name to now be "Circles Only", acronym is "CO" and description is "Sliders? Never heard of them." Clarified what the mod setting does a bit as well. About the tests, I saw TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset failed on single-threaded Linux and Windows before this change, although I'm not entirely sure why. https://github.com/ppy/osu/runs/36333043478#r3s0 As long as the tests and "CO" acronym is fine, and no other issues pop up, that should be all, but it seems switching modes between mania and standard with either mod on with this acronym enables Cover when switching to mania or Circles Only when switching to standard. Might be out of scope for this PR, though? |
Found and fixed two issues while messing with it, haven't encountered anything else so please let me know if any other issues crop up. |
This mod converts slider objects into circles.
Before
osu._DpuxTbGGPD.mp4
After
osu._tUXtVxXdFB.mp4
After with slider end/repeat conversion
osu._g5BWpRnESR.mp4
Likely needs a name, acronym, and description change, and suggestions are welcome. (
OnlyCircles?) Please let me know if there's anything else.