Avoid accessing WorkingBeatmap.Beatmap every update call
#31775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice in passing. Comes with overheads that can be easily avoided. Left a note for a future (slightly more involved) optimisation.
bdach
reviewed
Feb 3, 2025
Comment on lines
94
to
96
| double firstHitObjectTime = working.Beatmap.HitObjects.First().StartTime; | ||
| if (working.Beatmap.AudioLeadIn > 0) | ||
| time = Math.Min(time, firstHitObjectTime - working.Beatmap.AudioLeadIn); |
There was a problem hiding this comment.
There are three accesses to WorkingBeatmap.Beatmap here - maybe just pass the IBeatmap here too? I guess this is initialisation code so the overhead isn't going to be comparably large here, but given we're fixing already...?
bdach
approved these changes
Feb 3, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice in passing.
Comes with overheads that can be easily avoided. Left a note for a future (slightly more involved) optimisation.
Wouldn't have bothered with this because marginal-gains but it also makes the code/variables a bit easier to follow in the clock class.