Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add buffer state of disabled diagnostics state #981

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

prabirshrestha
Copy link
Owner

This is part of Diagnostics Revamp.

Helps for issues like these related to easymotion. #915

Currently this make sure the internal diagnostics state is up to date. It is still up to the ui implementations to respect the flag since get_all_diagnostics* function doesn't respect it for perf reasons. Updates to ui respecting this flag will come in separate PRs.

When I start updating UI to respect this I will expose a public documented api which will look something like this.

autocmd User EasyMotionPromptBegin call lsp#disable_diagnostics_for_buffer(bufnr('%'))<CR>
autocmd User EasyMotionPromptEnd call lsp#enable_diagnostics_for_buffer(bufnr('%'))<CR>

While I could have a method to disable per diagnsotics ui it made sense to do this for entire diagnostics features.

@prabirshrestha prabirshrestha merged commit 8f5bec6 into master Dec 28, 2020
@prabirshrestha prabirshrestha deleted the diagnostics-state-disable-buffer branch December 28, 2020 02:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant