Revamp diagnostics highlights #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabirshrestha
force-pushed
the
diagnostics-highlights
branch
from
e21c061 to
f4435cf
Compare
prabirshrestha
changed the title
This was referenced Jan 1, 2021
seandewar
added a commit
to seandewar/dotfiles
that referenced
this pull request
Feb 25, 2021
…l(), remove UTF symbols LSP highlights work a lot better since the revamp (prabirshrestha/vim-lsp#995), so we're happy to re-enable them (to be exact, the option name changed anyway, so the disable had no effect since the update) UTF just doesn't play nicely with some terminal/GUI configurations for Vim/Neovim, so just use plain-old ASCII until support is more reliable
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of Diagnostics Revamp and is about highlighting diagnostics information. It implements few feature asks as well as bugs.
textpropsand neovim'snvim_buf_add_higlightnvim_buf_add_higlighttextpropslet g:lsp_diagnostics_highlights_insert_mode_enabled = 0let lsp_diagnostics_highlights_delay = 5000startline == endline && startcol == endcolnothing gets highlightedendcolis end of column for start line.lsp#internal#diagnostics#state#_is_enabled_for_bufferIt is a breaking change due to flag name changes but is necessary to unify and make it consistent.