Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Scale down whenever possible if the worker is defined as disruptable #60

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Scale down whenever possible if the worker is defined as disruptable #60

merged 4 commits into from
Apr 6, 2020

Conversation

alok87
Copy link
Contributor

@alok87 alok87 commented Apr 6, 2020 •
edited
Loading

Fixes #50

Adds idempotent: flag in the WPA spec.

  • disruptable: false
WPA will scale down only to min when all workers have stopped processing.
  • disruptable: true
WPA will scale down to values between min and current if the calculated desired no of replicas falls to a lower number.

Default still is disruptable: false.

@alok87
Scale down whenever possible if the worker is idempotent
899e7ab 
Since we cannot assume workers were idempotent or not. We used to scale
down to minimum only when there was no processing happening. But since
our users told they want workers to scale down to a less number whenever
possible we have put this behind the "idempotent" flag to make it
possible for such workers to scale down from 30 to 25 to 22 to 19 to 10
to 0 instead of only 30 to 0.
@alok87 alok87 changed the title Scale down whenever possible if the worker is idempotent WIP: Scale down whenever possible if the worker is idempotent Apr 6, 2020
@alok87 alok87 changed the title WIP: Scale down whenever possible if the worker is idempotent Scale down whenever possible if the worker is idempotent Apr 6, 2020
@deplexbot deplexbot force-pushed the scale-down-idempotent branch from c01d5f7 to 1c50529 Compare April 6, 2020 15:07
@alok87 alok87 requested a review from justjkk April 6, 2020 15:09
@alok87 alok87 force-pushed the scale-down-idempotent branch from 1c50529 to 60e694b Compare April 6, 2020 15:16
@alok87 alok87 changed the title Scale down whenever possible if the worker is idempotent Scale down whenever possible if the worker is defined as disruptable Apr 6, 2020
@alok87 alok87 merged commit 2e73efd into master Apr 6, 2020
@alok87 alok87 deleted the scale-down-idempotent branch April 9, 2020 17:50
@justjkk justjkk mentioned this pull request Jul 16, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@justjkk justjkk justjkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only massive scale down is possible with WPA at present (WPA only supports scale down to min)
2 participants
@alok87 @justjkk