Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: waybar config options in config.ctl #1220

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Fix: waybar config options in config.ctl #1220

merged 1 commit into from
Apr 7, 2024

Conversation

Skerse
Copy link
Collaborator

@Skerse Skerse commented Mar 30, 2024

Pull Request

Description

  • Fixes 2 waybar config options that load improperly. (see images below)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

Before (How it currently behaves):
image
After (How it should behave):
image

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Mar 31, 2024

Actually it was an intended option to show that if the size is blank it will be defaulted to a certain size (1/3? or I think tittus wide screen). But this MR should be fine as users are confused with this. 🥳

@Skerse
Copy link
Collaborator Author

Skerse commented Mar 31, 2024

Actually it was an intended option to show that if the size is blank it will be defaulted to a certain size (1/3? or I think tittus wide screen).

As far as i know it never had a set size number so yeah it just defaults to a certain value, if we want to have a set size than okay, but i just wanted to fix a broken config issue right now.

@prasanthrangan
Copy link
Owner

Nice... This is already fixed in dev branch...

@prasanthrangan prasanthrangan merged commit 8ac2e5a into prasanthrangan:main Apr 7, 2024
@Skerse Skerse deleted the waybar-fix branch April 7, 2024 06:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants