-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Dynamic Browser Tab Title Handling Based on File Context #1202
Conversation
Now it will show the filename as browser tab title so that user can easily identify which file is opened on which tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of simplicity, I propose to remove lines 3722 and 3734, then replace line 3733 with:
echo isset($_GET['edit']) ? $_GET['edit'] : fm_enc(APP_TITLE);
remove lines 3722 and 3734 and add this directly in 3733 as per the suggestion of @ner00
Updated |
@jabedbd It's still pending the commented review. |
Hi, is there anything I can do from my side? i have already updated the code that you mentioned above. |
I think so, yes. Remove the trailing space in line 3721, after |
extra trailing space removed
Done. The extra trailing space is removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now it will show the filename as the browser tab title so that the user can easily identify which file is opened on which tab.