Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dynamic Browser Tab Title Handling Based on File Context #1202

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

jabedbd
Copy link
Contributor

@jabedbd jabedbd commented Jun 30, 2024

Now it will show the filename as the browser tab title so that the user can easily identify which file is opened on which tab.

Now it will show the filename as browser tab title so that user can easily identify which file is opened on which tab.
Copy link
Contributor

@ner00 ner00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of simplicity, I propose to remove lines 3722 and 3734, then replace line 3733 with:

    echo isset($_GET['edit']) ? $_GET['edit'] : fm_enc(APP_TITLE);

remove lines 3722 and 3734 and add this directly in  3733 as per the suggestion of @ner00
@jabedbd
Copy link
Contributor Author

jabedbd commented Jul 8, 2024

For the sake of simplicity, I propose to remove lines 3722 and 3734, then replace line 3733 with:

    echo isset($_GET['edit']) ? $_GET['edit'] : fm_enc(APP_TITLE);

Updated

@jabedbd jabedbd requested a review from ner00 July 25, 2024 10:46
@ner00
Copy link
Contributor

ner00 commented Jul 25, 2024

@jabedbd It's still pending the commented review.

@jabedbd
Copy link
Contributor Author

jabedbd commented Oct 1, 2024

@jabedbd It's still pending the commented review.

Hi, is there anything I can do from my side? i have already updated the code that you mentioned above.

@ner00
Copy link
Contributor

ner00 commented Oct 1, 2024

@jabedbd It's still pending the commented review.

Hi, is there anything I can do from my side? i have already updated the code that you mentioned above.

I think so, yes. Remove the trailing space in line 3721, after 'navbar-normal';, that was you who added that space, it did not exist before and doesn't need to be there anyway.

extra trailing space removed
@jabedbd
Copy link
Contributor Author

jabedbd commented Oct 1, 2024

@jabedbd It's still pending the commented review.

Hi, is there anything I can do from my side? i have already updated the code that you mentioned above.

I think so, yes. Remove the trailing space in line 3721, after 'navbar-normal';, that was you who added that space, it did not exist before and doesn't need to be there anyway.

Done. The extra trailing space is removed

Copy link
Contributor

@ner00 ner00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tinyfilemanager.php Outdated Show resolved Hide resolved
@prasathmani prasathmani merged commit 3716af2 into prasathmani:master Oct 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants