Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for Tz operator (horizontal scaling). #26

Merged
merged 4 commits into from
Jan 2, 2017
Merged

Add support for Tz operator (horizontal scaling). #26

merged 4 commits into from
Jan 2, 2017

Conversation

msbit
Copy link
Contributor

@msbit msbit commented Feb 19, 2016

Simple implementation of the Tz operator for allowing horizontal scaling of text.

@pointlessone
Copy link
Member

Hello @msbit. Thank you very much for your contribution.

I'll take a closer look at the code a bit later. Meanwhile could you please add a spec or two that cover new code?

@msbit
Copy link
Contributor Author

msbit commented Feb 19, 2016

Hey @pointlessone. I've based the implementation on character_spacing, and so I was thinking of adding them into a PR for https://github.com/prawnpdf/prawn, as all the character_spacing specs seem to be in place on there. Would that be okay?

@pointlessone
Copy link
Member

This is unfortunate consequence of extraction of PDF Core out of Prawn. There isn't always an obvious way to cut it.

Those specs definitely should belong here since the code is in this gem. Could you please file an issue about that since you've already inspected the code?

As for this PR we'd prefer specs here for this code and in Prawn gem for the code that uses this feature if any.

@msbit
Copy link
Contributor Author

msbit commented Feb 19, 2016

Okay, that sounds fair.

I'll look at the specs for this PR tomorrow, and while I'm investigating that I'll see if I can put together a reasonable overview of what would need to come across in terms of specs from prawn into pdf-core for character_spacing.

@pointlessone
Copy link
Member

@msbit Thank you. Much appreciated.

@msbit
Copy link
Contributor Author

msbit commented Feb 21, 2016

Added specs covering the pdf-core specific parts of this.

end
end
@mock = TextMock.new
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably would be better to move class definition out of before and use let instead to create a new mock for each example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that makes sense.

@msbit
Copy link
Contributor Author

msbit commented Jan 3, 2017

👌

@msbit msbit deleted the horizontal-scaling branch January 3, 2017 07:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants