-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for Tz operator (horizontal scaling). #26
Conversation
Hello @msbit. Thank you very much for your contribution. I'll take a closer look at the code a bit later. Meanwhile could you please add a spec or two that cover new code? |
Hey @pointlessone. I've based the implementation on character_spacing, and so I was thinking of adding them into a PR for https://github.com/prawnpdf/prawn, as all the character_spacing specs seem to be in place on there. Would that be okay? |
This is unfortunate consequence of extraction of PDF Core out of Prawn. There isn't always an obvious way to cut it. Those specs definitely should belong here since the code is in this gem. Could you please file an issue about that since you've already inspected the code? As for this PR we'd prefer specs here for this code and in Prawn gem for the code that uses this feature if any. |
Okay, that sounds fair. I'll look at the specs for this PR tomorrow, and while I'm investigating that I'll see if I can put together a reasonable overview of what would need to come across in terms of specs from prawn into pdf-core for character_spacing. |
@msbit Thank you. Much appreciated. |
Added specs covering the pdf-core specific parts of this. |
end | ||
end | ||
@mock = TextMock.new | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably would be better to move class definition out of before
and use let
instead to create a new mock for each example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that makes sense.
👌 |
Simple implementation of the Tz operator for allowing horizontal scaling of text.