Add frontend build to dev release #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only thing missing is the UEVRPluginNullifier.dll but I can probably add that in a separate commit |
|
Oh I didn't even notice that was missing lol |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see the result here: https://github.com/Raicuparta/UEVR/releases/latest
Not sure if you want to include the frontend in the PR builds too. This is a simple straightforward implementation that just builds one after the other. The smart way to do it would probably be building backend and frontend in separate jobs, then a third job that merges both and uploads. But the frontend is pretty quick to build, so I don't think it matters much.
Also ugh why did it reformat after I merged from upstream