Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Default to publishing single file #13

Merged
merged 4 commits into from
Feb 4, 2024
Merged

Default to publishing single file #13

merged 4 commits into from
Feb 4, 2024

Conversation

Raicuparta
Copy link
Collaborator

No description provided.

@Raicuparta Raicuparta marked this pull request as draft February 4, 2024 13:38
@Raicuparta Raicuparta marked this pull request as ready for review February 4, 2024 13:44
@praydog
Copy link
Owner

praydog commented Feb 4, 2024

Almost there, but looks like some random DLLs are in there still compared to a local VS publish

@Raicuparta Raicuparta marked this pull request as draft February 4, 2024 13:49
@Raicuparta
Copy link
Collaborator Author

yeah no idea what those are, was just doing a quick test since I'm not on Windows right now, will look further into it a bit

@Raicuparta Raicuparta marked this pull request as ready for review February 4, 2024 14:05
@Raicuparta
Copy link
Collaborator Author

Alright, there you go :) Took me a few attempts to make it not default to self-contained.

Self-contained means it bundles the entire .NET runtime (making the final build way bigger), and apparently also added some extra dlls. This is useful if you don't want users to have to install the runtime themselves, but probably worth it since Windows already gives helpful errors in that case. So I made it not self-contained.

PublishSingleFile is what actually makes it put all the dlls into the main exe.

@Raicuparta
Copy link
Collaborator Author

btw @praydog do you wanna get rid of the pdb and .config files in the release builds? That's pretty easy to do as well.

@praydog
Copy link
Owner

praydog commented Feb 4, 2024

Hmm, I don't want to do this for the backend, so not sure why I'd want to do it for the frontend. Though there is no crash logging, or any logging at all set up so it makes no sense for the frontend. At least for the backend, if I get a proper commit hash I can pull the PDB from the nightlies and properly analyze the dumps.

Copy link
Owner

@praydog praydog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine

@praydog praydog merged commit 931dbae into main Feb 4, 2024
2 checks passed
@Raicuparta Raicuparta deleted the publish-single-file branch February 4, 2024 14:28
@praydog
Copy link
Owner

praydog commented Feb 4, 2024

After thinking about it, yeah I'm okay with having those files removed - at least for the frontend. The less space occupied the better, if it's not necessary or useful to have the PDB for the frontend there. And at least for actions I believe they count towards my storage limit.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants