This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
bugfix: array[object] data children going to be an object #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
approved these changes
May 16, 2017
developit
suggested changes
May 16, 2017
src/index.js
Outdated
| @@ -500,7 +500,7 @@ function propsHook(props, context) { | |||
|
|
|||
| // React annoyingly special-cases single children, and some react components are ridiculously strict about this. | |||
| let c = props.children; | |||
| if (c && Array.isArray(c) && c.length===1) { | |||
| if (c && Array.isArray(c) && c.length===1 && (typeof c[0] === 'string' || c[0] instanceof VNode)) { | |||
There was a problem hiding this comment.
Need to also allow typeof c[0]==='function' here.
developit
approved these changes
May 17, 2017
developit
approved these changes
Jun 21, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bug breaks antd-mobile picker component.