This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Adding Aliasify global transform options #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately Browserify says you can't make global transforms from package.json: https://github.com/browserify/browserify#btransformtr-opts "If opts.global is true, the transform will operate on ALL files, despite whether they exist up a level in a node_modules/ directory. Use global transforms cautiously and sparingly, since most of the time an ordinary transform will suffice. You can also not configure global transforms in a package.json like you can with ordinary transforms."
developit
reviewed
Nov 1, 2018
| @@ -98,6 +98,18 @@ First, install it: `npm install --save-dev aliasify` | |||
| } | |||
There was a problem hiding this comment.
think it'd be possible to add "global":true to the package.json version above too? or is the global option only exposed when using the transform via Browserify's Node API?
There was a problem hiding this comment.
I tried to see if that works just in case but the documentation seems to say you can only use the global transform option from the api or the cli:
https://github.com/browserify/browserify#btransformtr-opts
"[...] You can also not configure global transforms in a package.json like you can with ordinary transforms."
There was a problem hiding this comment.
aw :( I wonder why they don't allow that
developit
approved these changes
Nov 2, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Browserify says you can't make global transforms from package.json:
https://github.com/browserify/browserify#btransformtr-opts
"If opts.global is true, the transform will operate on ALL files, despite whether they exist up a level in a node_modules/ directory. Use global transforms cautiously and sparingly, since most of the time an ordinary transform will suffice. You can also not configure global transforms in a package.json like you can with ordinary transforms."