Skip to content

Commit

Permalink
refactor: Skip dom check for inferring lower-cased event names (#4720)
Browse files Browse the repository at this point in the history
  • Loading branch information
rschristian authored Mar 9, 2025
1 parent 8b258f0 commit 151b2ef
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
9 changes: 2 additions & 7 deletions src/diff/props.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,8 @@ export function setProperty(dom, name, value, oldValue, namespace) {
else if (name[0] == 'o' && name[1] == 'n') {
useCapture = name != (name = name.replace(CAPTURE_REGEX, '$1'));

// Infer correct casing for DOM built-in events:
if (
name.toLowerCase() in dom ||
name == 'onFocusOut' ||
name == 'onFocusIn'
)
name = name.toLowerCase().slice(2);
// Infer correct casing for events:
if (name[2].toLowerCase() != name[2]) name = name.toLowerCase().slice(2);
else name = name.slice(2);

if (!dom._listeners) dom._listeners = {};
Expand Down
2 changes: 1 addition & 1 deletion test/browser/events.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('event handling', () => {
expect(
proto.addEventListener
).to.have.been.calledOnce.and.to.have.been.calledWithExactly(
'OtherClick',
'otherclick',
sinon.match.func,
false
);
Expand Down

0 comments on commit 151b2ef

Please # to comment.