fix: createElement & h types (#4578)

* fix: createElement & h types * test: Add type tests * chore: Backport fix to TS 5.0 types too
preactjs · Nov 29, 2024 · cf6942d · cf6942d
1 parent db47ab6
commit cf6942d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/index-5.d.ts b/src/index-5.d.ts
@@ -226,7 +226,7 @@ export function createElement<T extends HTMLElement>(
 	ClassAttributes<T> & JSXInternal.HTMLAttributes & JSXInternal.SVGAttributes
 >;
 export function createElement<P>(
-	type: ComponentType<P>,
+	type: ComponentType<P> | string,
 	props: (Attributes & P) | null,
 	...children: ComponentChildren[]
 ): VNode<P>;
@@ -276,7 +276,7 @@ export function h<T extends HTMLElement>(
 	| null
 >;
 export function h<P>(
-	type: ComponentType<P>,
+	type: ComponentType<P> | string,
 	props: (Attributes & P) | null,
 	...children: ComponentChildren[]
 ): VNode<Attributes & P>;

diff --git a/src/index.d.ts b/src/index.d.ts
@@ -210,7 +210,7 @@ export function createElement<
 	P extends JSXInternal.SVGAttributes<T>,
 	T extends HTMLElement
 >(
-	type: keyof JSXInternal.IntrinsicElements,
+	type: keyof JSXInternal.IntrinsicSVGElements,
 	props: (ClassAttributes<T> & P) | null,
 	...children: ComponentChildren[]
 ): VNode<ClassAttributes<T> & P>;
@@ -226,7 +226,7 @@ export function createElement<T extends HTMLElement>(
 	ClassAttributes<T> & JSXInternal.HTMLAttributes & JSXInternal.SVGAttributes
 >;
 export function createElement<P>(
-	type: ComponentType<P>,
+	type: ComponentType<P> | string,
 	props: (Attributes & P) | null,
 	...children: ComponentChildren[]
 ): VNode<P>;
@@ -257,7 +257,7 @@ export function h<
 	P extends JSXInternal.SVGAttributes<T>,
 	T extends HTMLElement
 >(
-	type: keyof JSXInternal.IntrinsicElements,
+	type: keyof JSXInternal.IntrinsicSVGElements,
 	props: (ClassAttributes<T> & P) | null,
 	...children: ComponentChildren[]
 ): VNode<ClassAttributes<T> & P>;
@@ -276,7 +276,7 @@ export function h<T extends HTMLElement>(
 	| null
 >;
 export function h<P>(
-	type: ComponentType<P>,
+	type: ComponentType<P> | string,
 	props: (Attributes & P) | null,
 	...children: ComponentChildren[]
 ): VNode<Attributes & P>;

diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
@@ -378,3 +378,6 @@ const onSubmit = (e: h.JSX.TargetedSubmitEvent<HTMLFormElement>) => {};
 <form onSubmit={e => e.currentTarget.elements} />;
 createElement('form', { onSubmit: onSubmit });
 h('form', { onSubmit: onSubmit });
+
+h('option', { value: 'foo' });
+createElement('option', { value: 'foo' });