Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add support for multiple roots with useId #3781

Open
1 task done
marvinhagemeister opened this issue Oct 27, 2022 · 2 comments
Open
1 task done

Add support for multiple roots with useId #3781

marvinhagemeister opened this issue Oct 27, 2022 · 2 comments

Comments

@marvinhagemeister
Copy link
Member

  • Check if updating to the latest Preact version resolves the issue

Describe the bug

There may be clashes in ids with multiple roots in the same page. This is a follow-up issue to #3772 . See: #3772 (comment)

To Reproduce

https://codesandbox.io/s/preact-useid-multiple-y0qbwq?file=/src/index.js

Expected behavior
What should have happened when following the steps above?
@fromaline
Copy link

I am interested in fixing this bug.
What is the expected behavior in this case? Unique id for each root, like in React?

@igorbrasileiro
Copy link

Do you know if we have news here? I'm interested in this because Deno Fresh islands architecture leverages multiple renders and causes this bug.

rtrbt added a commit to Tinkerforge/esp32-firmware that referenced this issue Oct 11, 2023
@rtrbt
web: Don't use useId for now.
2085d73 
Preact's useId does not work with multiple roots:
preactjs/preact#3781

Once the port to preact is complete,
we can switch back to Preact's useId.
photron pushed a commit to Tinkerforge/esp32-firmware that referenced this issue Oct 11, 2023
@rtrbt @photron
web: Don't use useId for now.
e5c7f0c 
Preact's useId does not work with multiple roots:
preactjs/preact#3781

Once the port to preact is complete,
we can switch back to Preact's useId.
@Kauhsa Kauhsa mentioned this issue Dec 1, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marvinhagemeister @igorbrasileiro @fromaline