Add support for `errorInfo` #3452

marvinhagemeister · 2022-02-14T01:02:50Z

This PR adds support for the errorInfo argument which is the second to componentDidCatch. In React it's used to pass the owner tree along. This is often used in combination with error logging. Note that we'll only collect component traces if preact/debug is loaded.

Fixes #2835, fixes #3118 .
Replaces #2836 .

github-actions · 2022-02-14T01:03:04Z

📊 Tachometer Benchmark Results

Summary

duration

02_replace1k: unsure 🔍 -1% - +3% (-1.50ms - +5.50ms)
^{preact-local vs preact-master}
03_update10th1k_x16: unsure 🔍 -4% - +5% (-1.27ms - +1.51ms)
^{preact-local vs preact-master}
07_create10k: unsure 🔍 -1% - +1% (-11.21ms - +18.53ms)
^{preact-local vs preact-master}
filter_list: unsure 🔍 -3% - +4% (-0.95ms - +1.32ms)
^{preact-local vs preact-master}
hydrate1k: unsure 🔍 -3% - +4% (-6.57ms - +8.94ms)
^{preact-local vs preact-master}
many_updates: unsure 🔍 -3% - +5% (-0.84ms - +1.52ms)
^{preact-local vs preact-master}
text_update: unsure 🔍 -4% - +3% (-0.13ms - +0.11ms)
^{preact-local vs preact-master}

usedJSHeapSize

02_replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
^{preact-local vs preact-master}
03_update10th1k_x16: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
^{preact-local vs preact-master}
07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-master}
filter_list: unsure 🔍 -1% - +3% (-0.01ms - +0.05ms)
^{preact-local vs preact-master}
hydrate1k: unsure 🔍 -1% - +0% (-0.05ms - +0.01ms)
^{preact-local vs preact-master}
many_updates: unsure 🔍 -1% - +0% (-0.03ms - +0.02ms)
^{preact-local vs preact-master}
text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-master}

Results

02_replace1k

Browser: chrome-headless 98.0.4758.80
Sample size: 80
Built by: Benchmarks #695
Commit: 0b35b2f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	177.89ms - 182.06ms	-	unsure 🔍 -3% - +1% -5.50ms - +1.50ms
preact-local	179.16ms - 184.78ms	unsure 🔍 -1% - +3% -1.50ms - +5.50ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.61ms - 3.63ms	-	unsure 🔍 -1% - +1% -0.02ms - +0.02ms
preact-local	3.61ms - 3.64ms	unsure 🔍 -1% - +1% -0.02ms - +0.02ms	-

run-warmup-0

Version	Avg time	vs preact-master	vs preact-local
preact-master	59.09ms - 61.16ms	-	unsure 🔍 -1% - +3% -0.79ms - +1.98ms
preact-local	58.60ms - 60.46ms	unsure 🔍 -3% - +1% -1.98ms - +0.79ms	-

run-warmup-1

Version	Avg time	vs preact-master	vs preact-local
preact-master	86.93ms - 90.63ms	-	unsure 🔍 -3% - +2% -2.96ms - +2.03ms
preact-local	87.58ms - 90.93ms	unsure 🔍 -2% - +3% -2.03ms - +2.96ms	-

run-warmup-2

Version	Avg time	vs preact-master	vs preact-local
preact-master	74.47ms - 80.91ms	-	unsure 🔍 -8% - +3% -6.39ms - +2.63ms
preact-local	76.42ms - 82.72ms	unsure 🔍 -3% - +8% -2.63ms - +6.39ms	-

run-warmup-3

Version	Avg time	vs preact-master	vs preact-local
preact-master	71.33ms - 78.24ms	-	unsure 🔍 -0% - +13% -0.20ms - +8.96ms
preact-local	67.39ms - 73.42ms	unsure 🔍 -12% - +0% -8.96ms - +0.20ms	-

run-warmup-4

Version	Avg time	vs preact-master	vs preact-local
preact-master	87.83ms - 92.01ms	-	unsure 🔍 -5% - +1% -4.70ms - +0.89ms
preact-local	89.96ms - 93.68ms	unsure 🔍 -1% - +5% -0.89ms - +4.70ms	-

run-final

Version	Avg time	vs preact-master	vs preact-local
preact-master	64.82ms - 67.50ms	-	unsure 🔍 -4% - +2% -2.52ms - +1.66ms
preact-local	64.99ms - 68.19ms	unsure 🔍 -3% - +4% -1.66ms - +2.52ms	-

03_update10th1k_x16

Browser: chrome-headless 98.0.4758.80
Sample size: 110
Built by: Benchmarks #695
Commit: 0b35b2f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	32.18ms - 34.10ms	-	unsure 🔍 -5% - +4% -1.51ms - +1.27ms
preact-local	32.25ms - 34.27ms	unsure 🔍 -4% - +5% -1.27ms - +1.51ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.44ms - 3.46ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.02ms
preact-local	3.44ms - 3.46ms	unsure 🔍 -1% - +0% -0.02ms - +0.01ms	-

07_create10k

Browser: chrome-headless 98.0.4758.80
Sample size: 50
Built by: Benchmarks #695
Commit: 0b35b2f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	1544.17ms - 1564.27ms	-	unsure 🔍 -1% - +1% -18.53ms - +11.21ms
preact-local	1546.92ms - 1568.85ms	unsure 🔍 -1% - +1% -11.21ms - +18.53ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	25.36ms - 25.36ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	25.36ms - 25.36ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter_list

Browser: chrome-headless 98.0.4758.80
Sample size: 50
Built by: Benchmarks #695
Commit: 0b35b2f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	32.88ms - 34.34ms	-	unsure 🔍 -4% - +3% -1.32ms - +0.95ms
preact-local	32.92ms - 34.67ms	unsure 🔍 -3% - +4% -0.95ms - +1.32ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.60ms - 1.63ms	-	unsure 🔍 -3% - +0% -0.05ms - +0.01ms
preact-local	1.61ms - 1.65ms	unsure 🔍 -1% - +3% -0.01ms - +0.05ms	-

hydrate1k

Browser: chrome-headless 98.0.4758.80
Sample size: 80
Built by: Benchmarks #695
Commit: 0b35b2f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	193.62ms - 204.70ms	-	unsure 🔍 -4% - +3% -8.94ms - +6.57ms
preact-local	194.92ms - 205.77ms	unsure 🔍 -3% - +4% -6.57ms - +8.94ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	6.23ms - 6.27ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.05ms
preact-local	6.21ms - 6.25ms	unsure 🔍 -1% - +0% -0.05ms - +0.01ms	-

many_updates

Browser: chrome-headless 98.0.4758.80
Sample size: 60
Built by: Benchmarks #695
Commit: 0b35b2f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	30.79ms - 32.49ms	-	unsure 🔍 -5% - +3% -1.52ms - +0.84ms
preact-local	31.16ms - 32.80ms	unsure 🔍 -3% - +5% -0.84ms - +1.52ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.67ms - 4.70ms	-	unsure 🔍 -0% - +1% -0.02ms - +0.03ms
preact-local	4.66ms - 4.69ms	unsure 🔍 -1% - +0% -0.03ms - +0.02ms	-

text_update

Browser: chrome-headless 98.0.4758.80
Sample size: 50
Built by: Benchmarks #695
Commit: 0b35b2f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.33ms - 3.53ms	-	unsure 🔍 -3% - +4% -0.11ms - +0.13ms
preact-local	3.36ms - 3.49ms	unsure 🔍 -4% - +3% -0.13ms - +0.11ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	0.82ms - 0.82ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	0.82ms - 0.82ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

coveralls · 2022-02-14T01:04:31Z

Coverage decreased (-0.0007%) to 99.625% when pulling 0b35b2f on error-info-2 into df2dbd8 on master.

github-actions · 2022-02-14T01:06:01Z

Size Change: +106 B (0%)

Total Size: 42.3 kB

Filename	Size	Change
`compat/dist/compat.js`	3.46 kB	+2 B (0%)
`compat/dist/compat.module.js`	3.45 kB	+5 B (0%)
`compat/dist/compat.umd.js`	3.52 kB	+5 B (0%)
`debug/dist/debug.js`	3.01 kB	+22 B (0%)
`debug/dist/debug.module.js`	3 kB	+18 B (0%)
`debug/dist/debug.umd.js`	3.09 kB	+18 B (0%)
`dist/preact.js`	3.98 kB	+12 B (0%)
`dist/preact.min.js`	4.01 kB	+9 B (0%)
`dist/preact.module.js`	4 kB	+9 B (0%)
`dist/preact.umd.js`	4.04 kB	+6 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`devtools/dist/devtools.js`	231 B	0 B
`devtools/dist/devtools.module.js`	240 B	0 B
`devtools/dist/devtools.umd.js`	307 B	0 B
`hooks/dist/hooks.js`	1.15 kB	0 B
`hooks/dist/hooks.module.js`	1.17 kB	0 B
`hooks/dist/hooks.umd.js`	1.23 kB	0 B
`jsx-runtime/dist/jsxRuntime.js`	317 B	0 B
`jsx-runtime/dist/jsxRuntime.module.js`	327 B	0 B
`jsx-runtime/dist/jsxRuntime.umd.js`	395 B	0 B
`test-utils/dist/testUtils.js`	437 B	0 B
`test-utils/dist/testUtils.module.js`	439 B	0 B
`test-utils/dist/testUtils.umd.js`	515 B	0 B

_{compressed-size-action}

src/internal.d.ts

src/diff/catch-error.js

adit-hotstar · 2022-03-29T11:24:15Z

When will this fix be released?

marvinhagemeister · 2022-03-29T19:16:11Z

@adit-hotstar just published 10.7.0 which includes this PR 👍

marvinhagemeister commented Feb 14, 2022

View reviewed changes

src/internal.d.ts Outdated Show resolved Hide resolved

marvinhagemeister commented Feb 14, 2022

View reviewed changes

src/diff/catch-error.js Show resolved Hide resolved

marvinhagemeister marked this pull request as draft February 14, 2022 14:34

marvinhagemeister force-pushed the error-info-2 branch 3 times, most recently from 50aa879 to 312479a Compare February 19, 2022 20:33

marvinhagemeister marked this pull request as ready for review February 19, 2022 20:39

marvinhagemeister requested review from andrewiggins, JoviDeCroock and developit February 19, 2022 20:39

developit approved these changes Feb 20, 2022

View reviewed changes

Add support for errorInfo arg in componentDidCatch

0b35b2f

marvinhagemeister force-pushed the error-info-2 branch from 312479a to 0b35b2f Compare February 20, 2022 08:08

marvinhagemeister merged commit 9ac3996 into master Feb 20, 2022

marvinhagemeister deleted the error-info-2 branch February 20, 2022 08:15

rschristian mentioned this pull request Apr 23, 2024

Remove errorInfo type from componentDidCatch #2707

Closed

This was referenced Oct 31, 2024

Re-export ErrorInfo type jose-torres-marin/preact#1

Closed

Re-export ErrorInfo type #4541

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `errorInfo` #3452

Add support for `errorInfo` #3452

marvinhagemeister commented Feb 14, 2022 •

edited

Loading

github-actions bot commented Feb 14, 2022 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

coveralls commented Feb 14, 2022 •

edited

Loading

github-actions bot commented Feb 14, 2022 •

edited

Loading

adit-hotstar commented Mar 29, 2022

marvinhagemeister commented Mar 29, 2022

Add support for errorInfo #3452

Add support for errorInfo #3452

Conversation

marvinhagemeister commented Feb 14, 2022 • edited Loading

github-actions bot commented Feb 14, 2022 • edited Loading

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

coveralls commented Feb 14, 2022 • edited Loading

github-actions bot commented Feb 14, 2022 • edited Loading

adit-hotstar commented Mar 29, 2022

marvinhagemeister commented Mar 29, 2022

Add support for `errorInfo` #3452

Add support for `errorInfo` #3452

marvinhagemeister commented Feb 14, 2022 •

edited

Loading

github-actions bot commented Feb 14, 2022 •

edited

Loading

coveralls commented Feb 14, 2022 •

edited

Loading

github-actions bot commented Feb 14, 2022 •

edited

Loading