Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/add mathml definitions #4214

Merged

Conversation

fekete965
Copy link
Contributor

This PR is trying to address the following issue: #4208
The MathML interfaces were based on the MDN documentation: https://developer.mozilla.org/en-US/docs/Web/MathML
The high commit count could look intimidating, but each commit contains a small change by introducing a new MathML tag.

@coveralls
Copy link

coveralls commented Nov 16, 2023

Coverage Status

coverage: 99.463%. remained the same
when pulling 6eb5309 on fekete965:feature/add-mathml-definitions
into f3d4271 on preactjs:main.

@fekete965
Copy link
Contributor Author

I will double-check each element and the corresponding definition this week.

@fekete965 fekete965 force-pushed the feature/add-mathml-definitions branch 4 times, most recently from 398c9ed to 84d14f2 Compare December 8, 2023 10:26
@fekete965 fekete965 marked this pull request as ready for review December 8, 2023 10:26
@fekete965
Copy link
Contributor Author

I think the PR is good for a review 🙈

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you so much for adding this 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants