fix: incorrect oninput event type #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
force-pushed
the
fix-input-event
branch
from
62b10cf to
0df2dbf
Compare
|
Not sure what coveralls is up to. This doesn't touch any of the files it complains about. |
marvinhagemeister
force-pushed
the
fix-input-event
branch
from
0df2dbf to
6017fd7
Compare
marvinhagemeister
force-pushed
the
fix-input-event
branch
from
6017fd7 to
5f816b4
Compare
JoviDeCroock
approved these changes
Dec 7, 2023
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the event type for
onInputis too generic. The browser passes anInputEventthere. Also noticed that I made an error in the way I typedonSubmitin #4220