Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

retain masks across render invocations #4245

Merged
merged 2 commits into from
Jan 2, 2024
Merged

retain masks across render invocations #4245

merged 2 commits into from
Jan 2, 2024

Conversation

JoviDeCroock
Copy link
Member

Fixes #4223

This carries over the existing mask to the root

@coveralls
Copy link

coveralls commented Dec 31, 2023

Coverage Status

coverage: 99.468% (+0.001%) from 99.467%
when pulling e08b25e on retain-use-id
into 13b0afb on main.

Copy link

github-actions bot commented Dec 31, 2023

Size Change: +78 B (0%)

Total Size: 59.8 kB

Filename Size Change
hooks/dist/hooks.js 1.55 kB +28 B (1%)
hooks/dist/hooks.module.js 1.59 kB +23 B (1%)
hooks/dist/hooks.umd.js 1.63 kB +27 B (1%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.98 kB 0 B
compat/dist/compat.module.js 3.9 kB 0 B
compat/dist/compat.umd.js 4.04 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.js 4.51 kB 0 B
dist/preact.min.js 4.54 kB 0 B
dist/preact.min.module.js 4.54 kB 0 B
dist/preact.min.umd.js 4.57 kB 0 B
dist/preact.module.js 4.53 kB 0 B
dist/preact.umd.js 4.59 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock changed the title retain masks across useId invocations retain masks across render invocations Dec 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useId generates duplicate identifiers in some cases when calling render from @preact/compat multiple times
3 participants