Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Support ComponentChild(ren) in compat render/hydrate/createPortal #4346

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

rschristian
Copy link
Member

Re: #4345

Unlikely to really matter, but every now and then we do see a user or two still using React imports in their apps for whatever reason so this'll fix their types if they're trying to render a string or whatnot.

createPortal does support ComponentChildren, that change isn't a typo.


Unrelated, but I'll make a note to run through one day and make our use of parent & container consistent -- I noticed we use them interchangeably, which, while not an issue per se, might confuse someone new to the API.

@coveralls
Copy link

Coverage Status

coverage: 99.605%. remained the same
when pulling 1fc799d on types/fix-hydrate-render-createPortal
into c1addc2 on main.

@rschristian rschristian merged commit aa95aa9 into main Apr 23, 2024
4 checks passed
@rschristian rschristian deleted the types/fix-hydrate-render-createPortal branch April 23, 2024 07:14
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants