Support { handleEvent() {} } object interface as a listener
#4538
Conversation
|
To run the tests:
|
|
Thanks, I had to install chrome using playwright but I could run the tests with that command! |
| export type EventHandler<E extends TargetedEvent> = { | ||
| bivarianceHack(event: E): void; | ||
| }['bivarianceHack']; | ||
| }['bivarianceHack'] | EventHandlerObject<E>; |
There was a problem hiding this comment.
This worked for my projects, but I'm still cautious of changing an exported type. It might be necessary to leave this intact and instead add to the attribute interfaces one-by-one.
There was a problem hiding this comment.
This seems to cause issues elsewhere (see #4581), though I'm not quite sure what it's even doing? If you have a moment, would love an explanation. A lot of this TS stuff flies right over my head
There was a problem hiding this comment.
I'll reply in the issue.
There was a problem hiding this comment.
Cheers, and no rush! If that's incorrect usage then fair enough too! I'm very much unfamiliar with what this is doing.
| if (options.event) e = options.event(e); | ||
| return "handleEvent" in eventHandler ? eventHandler.handleEvent(e) : eventHandler(e); |
There was a problem hiding this comment.
The method must be called using the dot syntax; pulling it as an intermediate value would prevent it from receiving the object as this. The alternative is .apply()/.call() but I suspect that would add even more to the size.
Currently a draft because I couldn't get tests to run.