Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ensure we unwrap custom .then() #4547

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Ensure we unwrap custom .then() #4547

merged 1 commit into from
Nov 9, 2024

Conversation

JoviDeCroock
Copy link
Member

Fixes #3219

Before this fix we would return { default: JSX.Element } which is obviously wrong 😅

rschristian
rschristian approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat type and TIL! Somehow I've never ran across infer before

@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling cbeb27f on fix-lazy-types
into aee8285 on main.

@JoviDeCroock JoviDeCroock merged commit 76d6d4d into main Nov 9, 2024
5 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-lazy-types branch November 9, 2024 07:15
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 21, 2024
Merged
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 29, 2024
Closed
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rschristian rschristian rschristian approved these changes

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lazy produces TypeScript error: JSX element type 'Component' does not have any construct or call signatures
3 participants
@JoviDeCroock @coveralls @rschristian