Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Try constant for undefined #4552

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Try constant for undefined #4552

merged 2 commits into from
Nov 12, 2024

Conversation

JoviDeCroock
Copy link
Member

No description provided.

Copy link

github-actions bot commented Nov 11, 2024

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -2% - +0% (-15.44ms - +2.20ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +4% (-0.24ms - +0.70ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +3% (-1.02ms - +1.84ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +1% (-0.44ms - +0.20ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.18ms - +1.85ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -6% - +3% (-0.12ms - +0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +0% (-0.63ms - +0.13ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +4% (-0.65ms - +1.27ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +3% (-0.43ms - +0.45ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: slower ❌ 0% - 1% (0.00ms - 0.04ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local934.41ms - 942.74ms-unsure 🔍
-2% - +0%
-15.44ms - +2.20ms
preact-main937.43ms - 952.97msunsure 🔍
-0% - +2%
-2.20ms - +15.44ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.28ms - 25.29ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main25.28ms - 25.29msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.34ms - 17.26ms-unsure 🔍
-1% - +4%
-0.24ms - +0.70ms
preact-main16.46ms - 16.68msunsure 🔍
-4% - +1%
-0.70ms - +0.24ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.66ms - 1.68ms-unsure 🔍
-1% - +1%
-0.02ms - +0.01ms
preact-main1.66ms - 1.69msunsure 🔍
-1% - +1%
-0.01ms - +0.02ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.48ms - 73.17ms-unsure 🔍
-1% - +3%
-1.02ms - +1.84ms
preact-main70.92ms - 71.90msunsure 🔍
-3% - +1%
-1.84ms - +1.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local12.78ms - 13.35ms-unsure 🔍
-3% - +3%
-0.43ms - +0.45ms
preact-main12.71ms - 13.40msunsure 🔍
-3% - +3%
-0.45ms - +0.43ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local17.72ms - 18.15ms-unsure 🔍
-2% - +1%
-0.44ms - +0.20ms
preact-main17.82ms - 18.28msunsure 🔍
-1% - +2%
-0.20ms - +0.44ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.57ms - 4.60ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-main4.58ms - 4.61msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4039
  • Commit: c0fcd96

duration

VersionAvg timevs preact-localvs preact-main
preact-local75.49ms - 77.66ms-unsure 🔍
-2% - +2%
-1.18ms - +1.85ms
preact-main75.18ms - 77.30msunsure 🔍
-2% - +2%
-1.85ms - +1.18ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.57ms - 3.59ms-unsure 🔍
-1% - +1%
-0.03ms - +0.02ms
preact-main3.56ms - 3.60msunsure 🔍
-1% - +1%
-0.02ms - +0.03ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local31.19ms - 31.94ms-unsure 🔍
-0% - +3%
-0.07ms - +0.99ms
preact-main30.72ms - 31.48msunsure 🔍
-3% - +0%
-0.99ms - +0.07ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.60ms - 37.13ms-unsure 🔍
-3% - +3%
-1.00ms - +1.10ms
preact-main35.59ms - 37.04msunsure 🔍
-3% - +3%
-1.10ms - +1.00ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.77ms - 26.34ms-unsure 🔍
-1% - +2%
-0.28ms - +0.43ms
preact-main25.77ms - 26.20msunsure 🔍
-2% - +1%
-0.43ms - +0.28ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.90ms - 29.57ms-unsure 🔍
-5% - +3%
-1.45ms - +0.91ms
preact-main28.17ms - 29.85msunsure 🔍
-3% - +5%
-0.91ms - +1.45ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local20.25ms - 20.82ms-unsure 🔍
-3% - +2%
-0.55ms - +0.37ms
preact-main20.26ms - 20.99msunsure 🔍
-2% - +3%
-0.37ms - +0.55ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.85ms - 23.55ms-unsure 🔍
-2% - +2%
-0.47ms - +0.52ms
preact-main22.83ms - 23.53msunsure 🔍
-2% - +2%
-0.52ms - +0.47ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 220
  • Built by: CI #4039
  • Commit: c0fcd96

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.13ms - 2.27ms-unsure 🔍
-6% - +3%
-0.12ms - +0.06ms
preact-main2.17ms - 2.29msunsure 🔍
-3% - +6%
-0.06ms - +0.12ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.11ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.52ms - 33.76ms-unsure 🔍
-2% - +0%
-0.63ms - +0.13ms
preact-main33.53ms - 34.25msunsure 🔍
-0% - +2%
-0.13ms - +0.63ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.22ms - 1.23ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.22ms - 1.22msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.67ms - 36.09ms-unsure 🔍
-2% - +4%
-0.65ms - +1.27ms
preact-main34.42ms - 35.71msunsure 🔍
-4% - +2%
-1.27ms - +0.65ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.53ms - 3.56ms-slower ❌
0% - 1%
0.00ms - 0.04ms
preact-main3.52ms - 3.53msfaster ✔
0% - 1%
0.00ms - 0.04ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Nov 11, 2024

Size Change: -15 B (-0.02%)

Total Size: 62.3 kB

Filename Size Change
dist/preact.min.js 4.71 kB -7 B (-0.15%)
dist/preact.min.umd.js 4.74 kB -6 B (-0.13%)
dist/preact.umd.js 4.76 kB -2 B (-0.04%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.13 kB
compat/dist/compat.module.js 4.06 kB
compat/dist/compat.umd.js 4.19 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.69 kB
dist/preact.min.module.js 4.72 kB
dist/preact.module.js 4.71 kB
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 976 B
jsx-runtime/dist/jsxRuntime.module.js 949 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Nov 11, 2024

Coverage Status

coverage: 99.486% (-0.002%) from 99.488%
when pulling 5dea1d4 on try-constant-undefined
into bedd413 on main.

@JoviDeCroock JoviDeCroock merged commit 514183f into main Nov 12, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the try-constant-undefined branch November 12, 2024 06:48
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants