Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add dialog closedby types #4693

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feat: Add dialog closedby types #4693

merged 1 commit into from
Feb 18, 2025
+2 −0

Conversation

lukewarlow
Copy link
Contributor

@github-actions GitHub Actions
Copy link

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for CI

marvinhagemeister
marvinhagemeister approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@coveralls
Copy link

Coverage Status

coverage: 99.609%. remained the same
when pulling e5a6dcf on lukewarlow:dialog-closedby
into 927fdd4 on preactjs:main.

@marvinhagemeister marvinhagemeister merged commit 66fa1b5 into preactjs:main Feb 18, 2025
5 checks passed
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 26, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukewarlow @coveralls @marvinhagemeister