Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Michao Bid Adapter: Initial release #12507

Merged
merged 29 commits into from
Feb 17, 2025
Merged

Michao Bid Adapter: Initial release #12507

merged 29 commits into from
Feb 17, 2025

Conversation

hogekai
Copy link
Contributor

@hogekai hogekai commented Nov 26, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

{
  bidder: 'michao',
  params: {
    placement: "inbanner",
    site: 1,
    test: true
  }
}

Other information

@hogekai hogekai requested a review from patmmccann January 1, 2025 19:30
@patmmccann
Copy link
Collaborator

This appears to add a lot of unhandled rejection messages to the circleci log

Is it possible to make it less noisy? And if not, could it be more explicit in where the logs messages are coming from?

Compare to master at:
https://app.circleci.com/pipelines/github/prebid/Prebid.js/24014/workflows/5d8fa6eb-8201-4d95-b324-2089793d5229/jobs/42427

@hogekai
Copy link
Contributor Author

hogekai commented Jan 7, 2025

It is unclear why this build fails. What should I do?

@hogekai hogekai requested a review from patmmccann January 7, 2025 05:03
@ChrisHuie
Copy link
Collaborator

It is unclear why this build fails. What should I do?

Just needed to be reran because it disconnected.

@hogekai
Copy link
Contributor Author

hogekai commented Jan 8, 2025

@ChrisHuie
thank you!

@hogekai
Copy link
Contributor Author

hogekai commented Jan 29, 2025

Hi team,
Could you please review this?
I have made the following changes:

  • Removed OpenRTB-related parameters and modified the code to use prebid.js ortb parameters instead
  • Relocated extension parameters
  • Updated the version specification in InRenderer.js to only include major version number to better align with semantic versioning

Thanks!

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working in testing.

@Rothalack Rothalack merged commit 27aab5c into prebid:master Feb 17, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants