Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PubMatic Analytics Adapter: Moving slot level parameters to root level and adding few parameters to log in tracker #12665

Merged
merged 16 commits into from
Jan 21, 2025
Merged

PubMatic Analytics Adapter: Moving slot level parameters to root level and adding few parameters to log in tracker #12665

merged 16 commits into from
Jan 21, 2025

Conversation

pm-priyanka-deshmane
Copy link
Contributor

Type of change

  • Feature

Description of change

  • Moved ffs,fsrc,fp fields to root level similar to server side profiles
  • Logging fv field as final floor value
  • Added fmv, fsrc, fp, ft, frv & fv in tracker call

Other information

pm-priyanka-deshmane and others added 16 commits October 8, 2024 13:43
@pm-priyanka-deshmane
Moved floors fields at root level from slot level
8499d4d
@pm-priyanka-deshmane
Added fv value in logger and tracker
70b226a
@pm-priyanka-deshmane
Added safecheck for null object
7d8f5a1
@pm-priyanka-deshmane
Merge pull request #3 from pm-priyanka-deshmane/master
71ef4f8 
Master
@pm-priyanka-deshmane
Merge branch 'prebid:master' into UOE-11208
b4f1b3a
@pm-priyanka-deshmane
Reading frv,fv value from bidResponse floorData instead of auctionCache
52de36b
@pm-priyanka-deshmane
Merge branch 'prebid:master' into UOE-11208
b8659a1
@pm-priyanka-deshmane
Merge branch 'prebid:master' into UOE-11208
857cc91
@pm-priyanka-deshmane
Merge branch 'prebid:master' into UOE-11208
806a889
@pm-priyanka-deshmane
targeting keys issue when sendAllBids is true
2b6ed1b
@pm-priyanka-deshmane
Merge branch 'prebid:master' into UOE-11208
8b8f3c9
@pm-priyanka-deshmane
Merge branch 'prebid:master' into UOE-11208
d17df3b
@pm-priyanka-deshmane
Merge branch 'prebid:master' into UOE-11611
b08648a
@pm-priyanka-deshmane
Merge pull request #4 from pm-priyanka-deshmane/UOE-11611
0d7738b 
Merging targeting keys issue in floors
@pm-priyanka-deshmane
Merge branch 'prebid:master' into UOE-11208
55bd4df
@pm-priyanka-deshmane
Removed unused function
e5bd273
@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • modules/pubmaticAnalyticsAdapter.js (+4 errors)

@patmmccann
Copy link
Collaborator

@pm-priyanka-deshmane please fix your linting errors

jlquaccia
jlquaccia approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@jlquaccia jlquaccia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and looks as though all checks are passing)

@jlquaccia jlquaccia merged commit 9355e47 into prebid:master Jan 21, 2025
4 checks passed
@dgirardi dgirardi mentioned this pull request Jan 22, 2025
Merged
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jlquaccia jlquaccia jlquaccia approved these changes

Assignees
No one assigned
Labels
needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm-priyanka-deshmane @patmmccann @jlquaccia