Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Core: mild speedup on deepEqual #12717

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Core: mild speedup on deepEqual #12717

merged 3 commits into from
Feb 13, 2025

Conversation

patmmccann
Copy link
Collaborator

Refactor with the same behavior. A bit faster for arrays, also avoids repeated calls to Object.keys

@patmmccann
Core: mild speedup on deepEqual
58b6d05 
a bit faster for arrays, also avoids repeated calls to Object.keys
@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • src/utils.js (+3 errors)

@patmmccann
Copy link
Collaborator Author

benchmarking in progress at https://github.com/bbaresic/util-bench

@patmmccann
Copy link
Collaborator Author

speedup stats
image

@patmmccann
Copy link
Collaborator Author

c @bbaresic

@patmmccann patmmccann merged commit 7a66733 into master Feb 13, 2025
6 checks passed
@patmmccann patmmccann deleted the patmmccann-patch-13 branch February 13, 2025 17:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dgirardi dgirardi dgirardi approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patmmccann @dgirardi