Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mediago Bid Adapter : add param publisherid #12753

Merged
merged 15 commits into from
Feb 13, 2025
Merged

Conversation

BaronJHYu
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • modules/mediagoBidAdapter.js (+3 errors)

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • modules/mediagoBidAdapter.js (+3 errors)

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 39 linter errors (possibly disabled through directives):

  • libraries/cookieSync/cookieSync.js (+37 errors)
  • modules/discoveryBidAdapter.js (+1 error)
  • modules/mediagoBidAdapter.js (+1 error)

Copy link

Tread carefully! This PR adds 7 linter errors (possibly disabled through directives):

  • libraries/cookieSync/cookieSync.js (+5 errors)
  • modules/discoveryBidAdapter.js (+1 error)
  • modules/mediagoBidAdapter.js (+1 error)

Copy link

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • libraries/cookieSync/cookieSync.js (+2 errors)

Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • libraries/cookieSync/cookieSync.js (+1 error)

Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • libraries/cookieSync/cookieSync.js (+1 error)

Copy link

Tread carefully! This PR adds 8 linter errors (possibly disabled through directives):

  • libraries/cookieSync/cookieSync.js (+8 errors)

@patmmccann patmmccann self-assigned this Feb 13, 2025
@patmmccann patmmccann merged commit af5703d into prebid:master Feb 13, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants