PubMatic Bid Adapter : passing POS value from mediaType #12768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logic to send pos to pubmatic adapter 1st draft Changes change in pos logic Update pubmaticBidAdapter.js updated test case for pos Update pubmaticAnalyticsAdapter.js changes sending pos in translator and test cases fix Update pubmaticBidAdapter.js
pm-asit-sahoo
force-pushed
the
UOE-11940
branch
from
c05e0d8 to
341ed90
Compare
ChrisHuie
changed the title
ChrisHuie
approved these changes
Feb 18, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st draft Changes
change in pos logic
Update pubmaticBidAdapter.js
updated test case for pos
Update pubmaticAnalyticsAdapter.js
changes sending pos in translator and test cases fix
Update pubmaticBidAdapter.js
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Earlier in PubMatic Bid Adapter the value of imp.banner.pos was hard coded as 0, now we are accepting the values set in bid.mediaType and passing it to our adapter.
Other information