Prebid Core: update governance.md #8572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
reviewed
Jun 16, 2022
mkendall07
reviewed
Jun 16, 2022
| @@ -9,15 +9,31 @@ This document describes the governance model for the Prebid project. The Prebid | |||
|
|
|||
| ### Roles and Responsibilities: | |||
| - **User:** Any individual who consumes / uses the Prebid.js library. | |||
| - **Contributor:** Any individual who contributes code that is subsequently merged to the project. Contributed code is governed by the Prebid.js [license](https://github.com/prebid/Prebid.js/blob/master/LICENSE). Contributors are required to sign a CLA before any code can be committed (CLA pending). | |||
| - **Core Team Member:** An individual contributor who has been appointed by the Tech Lead on the project to maintain it and further it’s stated goals. | |||
| - **Contributor:** Any individual who contributes code that is subsequently merged to the project. Contributed code is governed by the Prebid.js [license](https://github.com/prebid/Prebid.js/blob/master/LICENSE). | |||
There was a problem hiding this comment.
did we ever end up implementing a CLA?
There was a problem hiding this comment.
Yes, there's a CLA, but it's not currently enforced.
mkendall07
reviewed
Jun 16, 2022
| - **Contributor:** Any individual who contributes code that is subsequently merged to the project. Contributed code is governed by the Prebid.js [license](https://github.com/prebid/Prebid.js/blob/master/LICENSE). Contributors are required to sign a CLA before any code can be committed (CLA pending). | ||
| - **Core Team Member:** An individual contributor who has been appointed by the Tech Lead on the project to maintain it and further it’s stated goals. | ||
| - **Contributor:** Any individual who contributes code that is subsequently merged to the project. Contributed code is governed by the Prebid.js [license](https://github.com/prebid/Prebid.js/blob/master/LICENSE). | ||
| - **Core & Review Team Member:** An individual contributor who has been appointed by the Tech Lead on the project to maintain it and further it’s stated goals. |
There was a problem hiding this comment.
Do we want to add anything here about prebid org membership? Do we have any reviewers not part of Prebid org?
There was a problem hiding this comment.
It appears all reviewers are members
There was a problem hiding this comment.
I'm not sure if we want to revoke core team status upon member company departure, but it hasn't come up yet afaik. Mark for example just asked to be taken off upon departure from Magnite.
There was a problem hiding this comment.
yeah I was thinking about that, I don't think we need to limit it to member companies at this time.
mkendall07
reviewed
Jun 16, 2022
mkendall07
reviewed
Jun 17, 2022
governance.md
Outdated
| - **Core Team Member:** An individual contributor who has been appointed by the Tech Lead on the project to maintain it and further it’s stated goals. | ||
| - **Contributor:** Any individual who contributes code that is subsequently merged to the project. Contributed code is governed by the Prebid.js [license](https://github.com/prebid/Prebid.js/blob/master/LICENSE). | ||
| - **Core & Review Team Member:** An individual contributor who has been appointed by the Tech Lead on the project to maintain it and further it’s stated goals. | ||
| - **Identity Team Member:** An individual contributor who has been appointed by the Identity PMC to review and maintain the identity modules and further the PMC stated goals. | ||
| - **Tech Lead:** The Tech Lead is responsible for overall technical direction of the project. The Tech Lead will work closely with Core Team members to facilitate development and further the project goals. |
There was a problem hiding this comment.
should we replace "tech lead" with PMC Chair?
There was a problem hiding this comment.
Line 5 declares them to be the same
There was a problem hiding this comment.
I added reference to that responsibility on this line as well
mkendall07
approved these changes
Jun 17, 2022
bretg
approved these changes
Jun 17, 2022
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
* Update governance.md * Update governance.md * Update governance.md * Update governance.md * Update governance.md * Update governance.md * Update governance.md * Update governance.md
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
* Update governance.md * Update governance.md * Update governance.md * Update governance.md * Update governance.md * Update governance.md * Update governance.md * Update governance.md
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was quite out of date. The line between reviewer and core team member is hazy, so I combined them here.